move to requiring Node 6 when LTS

[brendankenny]

With the release of 6.2.2, I think it may be time.

• Node 6 will be the next LTS version (skipping 5)
• it will give us a few more es6 features like
  • default parameters (avoiding the || defaultValue dance and especially eliminating the verbose cases of checking a value that may be falsy since default parameters always check against undefined)
  • rest parameters (allowing us to avoid noise like this and this)
  • Array.prototype.includes
  • destructuring (which I'm a bit wary of because every person I've seen use it quickly starts abusing readability for the sake of cool destructuring, but there's no way up but through :)
• there are no notable language changes in the pipeline for Node 7 (sorry **), which means lighthouse devs can use node 6+ and any language feature used will be compatible with a node 6 baseline (modulo performance improvements). This has been a problem in a few PRs in the past, where someone running node 6 has to rewrite when their change breaks in testing on node 5. Only caveat here is async/await, which has enough demand that we may need to upgrade when that's turned on.
• I assume the new DevTools debugging? Is this going to be in 6 or skip to 7?

[wardpeet]

maybe add a .nvmrc file as well for the nvm users while helping out :)

[addyosmani]

I assume the new DevTools debugging? Is this going to be in 6 or skip to 7?

I believe this is being skipped to 7

[paulirish]

I don't think we need to be in a rush here. A few folks who want to use Lighthouse are on v4 still, and v5 is a challenge for them.

Once LTS ships in october, we'll be in a better place for this sort of upgrade. But until then, I'm in favor of staying with 5.

[brendankenny]

I'd be ok waiting on 6 until it hits LTS

[wardpeet]

@brendankenny @paulirish we have hit lts for node 6, should we move on?

[wardpeet]

i'll close this, we will move whenever we are ready :)

[brendankenny]

resurrecting this issue. I think we're ready to drop anything before v6.9. We don't want to go tooooo crazy with new features, but dropping older versions from Travis, dropping $__node_harmony, etc can proceed.

[brendankenny]

@XhmikosR hopefully this makes your life much easier :)

[XhmikosR]

Woo-hoo! Looking forward to this as it will allow us to test everything on Windows. Well, after we sort a couple of other minor issues :) PS. Might be a good time to make sure the engines property is consistent in all package.json files.

…

On Jan 24, 2017 22:20, "Brendan Kenny" ***@***.***> wrote: @XhmikosR <https://github.com/XhmikosR> hopefully this makes your life much easier :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#449 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtTBYqEagIHkYYgVlBvLj-PP08z9Yks5rVl0GgaJpZM4I4ua6> .