core: handle DOM.resolveNode errors (#5427)

GoogleChrome · Jun 5, 2018 · 8f23052 · 8f23052
1 parent 4826a77
commit 8f23052
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lighthouse-core/gather/gatherers/dobetterweb/all-event-listeners.js b/lighthouse-core/gather/gatherers/dobetterweb/all-event-listeners.js
@@ -54,7 +54,14 @@ class EventListeners extends Gatherer {
       promise = driver.sendCommand('DOM.resolveNode', {
         nodeId: nodeIdOrObject,
         objectGroup: 'event-listeners-gatherer', // populates event handler info.
-      }).then(result => result.object);
+      })
+      .then(result => result.object)
+      .catch(() => {
+        return {
+          objectId: null,
+          description: '',
+        };
+      });
     }
 
     return promise.then(obj => {

diff --git a/lighthouse-core/lib/element.js b/lighthouse-core/lib/element.js
@@ -63,7 +63,8 @@ class Element {
           return null;
         }
         return this.driver.getObjectProperty(resp.object.objectId, propName);
-      });
+      })
+      .catch(() => null);
   }
 }