Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid unittest link oom #2962

Merged
merged 4 commits into from
May 9, 2024
Merged

fix: avoid unittest link oom #2962

merged 4 commits into from
May 9, 2024

Conversation

tychoish
Copy link
Collaborator

@tychoish tychoish commented May 8, 2024

This is partially speculative, but the general plan is:

  • move the integration tests out of the cli crate because they're
    orthogonal (they depend on the binary existing, which is already
    taken care of), and (would seem likely to) create a lot of linking
    workload.

  • disable doctests in places where they aren't needed (this mostly
    just reduces noise in the test output that I found confusing)

  • collapse legacy makefile testing. (I think passing workspace
    invalidates some cache for local builds, so this will probably make
    things easier in the long run.)

  • disable test builds for all packages that don't actually have
    tests. We'll still have to compile them as dependencies, but
    hopefully that's easier.

In the future we should rename the CI task, but that's fussy and
breaks PR for fussiness. Can try to remember to change later.

@tychoish tychoish merged commit ffbadc6 into main May 9, 2024
26 checks passed
@tychoish tychoish deleted the tycho/unittest-optimization branch May 9, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants