Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: case sensitive with cast for delta #2876

Merged
merged 1 commit into from
Apr 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/datasources/src/native/access.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use datafusion::common::ToDFSchema;
use datafusion::datasource::TableProvider;
use datafusion::error::Result as DataFusionResult;
use datafusion::execution::context::SessionState;
use datafusion::logical_expr::{col, Cast, LogicalPlan, TableProviderFilterPushDown, TableType};
use datafusion::logical_expr::{ident, Cast, LogicalPlan, TableProviderFilterPushDown, TableType};
use datafusion::physical_expr::create_physical_expr;
use datafusion::physical_expr::execution_props::ExecutionProps;
use datafusion::physical_plan::empty::EmptyExec;
Expand Down Expand Up @@ -448,10 +448,10 @@ impl TableProvider for NativeTable {
.zip(schema.fields())
.map(|(f1, f2)| {
let expr = if f1.data_type() == f2.data_type() {
col(f1.name())
ident(f1.name())
} else {
let cast_expr =
Cast::new(Box::new(col(f1.name())), f2.data_type().clone());
Cast::new(Box::new(ident(f1.name())), f2.data_type().clone());
Expr::Cast(cast_expr)
};
let execution_props = ExecutionProps::new();
Expand Down
7 changes: 7 additions & 0 deletions testdata/sqllogictests/create_table.slt
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,10 @@ select * from "Case_Sensitive"
statement ok
select * from "Case Sensitive"


# https://github.com/GlareDB/glaredb/issues/2777
statement ok
create table test as select vector, point as "Point" from lance_scan('./testdata/lance/table1');

statement ok
select * from test;