chore: add dbt test and fixtures #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tychoish
approved these changes
Feb 2, 2024
| def test_dbt_glaredb( | ||
| glaredb_connection: psycopg2.extensions.connection, | ||
| ): | ||
| dbt: dbtRunner = dbtRunner() |
There was a problem hiding this comment.
I wonder if you can just add this as an argument to the test to see if the magic pytest fixture thing works.
There was a problem hiding this comment.
Could you say more here? Are you suggesting I create a separate dbtRunner fixture?
tests/tests/test_dbt.py
Outdated
| project_directory: str = "../fixtures/dbt_project/" # TODO | ||
| dbt_profiles_directory: str = "../fixtures/dbt_project/" # TODO | ||
|
|
||
| curr = glaredb_connection.cursor() |
There was a problem hiding this comment.
context manager for cursors.
There was a problem hiding this comment.
Fixed. I followed the pattern here. Should we update that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is messy, but works. I haven't updated dependencies or anything, but dbt is a dependency for this. Just want to get this shared before the weekend.