Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Refator BaseVersionV2 into BaseVersion #3973

Merged
merged 6 commits into from
Mar 21, 2024
Merged

[Improvement] Refator BaseVersionV2 into BaseVersion #3973

merged 6 commits into from
Mar 21, 2024

Conversation

HHobeck
Copy link
Contributor

@HHobeck HHobeck commented Mar 20, 2024

Description

Close #3916

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@arturcic
Copy link
Member

@HHobeck please rebase the PR and I will have a look

@HHobeck HHobeck force-pushed the feature/refactoring-base-version branch from 85307b4 to 58e68f1 Compare March 21, 2024 08:19
@arturcic
Copy link
Member

@HHobeck can you check these warnings https://github.com/GitTools/GitVersion/pull/3973/files#annotation_19544676058?

arturcic
arturcic reviewed Mar 21, 2024
View reviewed changes
src/GitVersion.sln Outdated Show resolved Hide resolved
arturcic
arturcic reviewed Mar 21, 2024
View reviewed changes
src/GitVersion.sln Outdated Show resolved Hide resolved
@arturcic arturcic enabled auto-merge March 21, 2024 10:45
@arturcic arturcic merged commit 7f147ed into GitTools:main Mar 21, 2024
138 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 21, 2024

Thank you @HHobeck for your contribution!

@arturcic arturcic modified the milestone: 6.x May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturcic arturcic arturcic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] Refator BaseVersionV2 into BaseVersion
2 participants
@HHobeck @arturcic