-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the logic inheriting BranchConfiguration from parent branch if the IncrementStrategy is set to Inherit #3190
Commits on Sep 9, 2022
-
The behavior of GitVersion is sometimes not like I would expected it.…
… Here is my view on it and an example how it might be better. Not all unit tests are adapted right now from me. But this tests I have touched it looks quite good... That means the unit tests might be not correct implemented and false positive (or I have a fundamental different view on generating semantic versions). Hope this finds a way to a productive version of GitVersion because I put a lot of effort to this because I want to give something back. GitVersion is great and should be refactored more in direction of clean code. Thank you very much for given this a chance.
Configuration menu - View commit details
-
Copy full SHA for 5c619d6 - Browse repository at this point
Copy the full SHA 5c619d6View commit details -
Okay I changed the unit and agree on the result. It feels very natura…
…l like I would expected it. But at one point I'm not certain. That's related how the version should be incremented when having a different VersioningMode ContinuousDelivery, ContinuousDeployment or Mainline. I think I have misinterpreted the parameter TrackMergeTarget and should be using instead the ContinuousDeployment value instead.
Configuration menu - View commit details
-
Copy full SHA for f2ea9df - Browse repository at this point
Copy the full SHA f2ea9dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c1e64a - Browse repository at this point
Copy the full SHA 3c1e64aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0431671 - Browse repository at this point
Copy the full SHA 0431671View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12a6ecc - Browse repository at this point
Copy the full SHA 12a6eccView commit details
Commits on Sep 10, 2022
-
Set back the default behavior and change the configuration builder: s…
…et TrackMergeTarget to true for the main branch.
Configuration menu - View commit details
-
Copy full SHA for 2f89159 - Browse repository at this point
Copy the full SHA 2f89159View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01100f2 - Browse repository at this point
Copy the full SHA 01100f2View commit details -
Set back the default behavior and change the configuration builder: s…
…et TrackMergeTarget to true for the support branch.
Configuration menu - View commit details
-
Copy full SHA for dcec44f - Browse repository at this point
Copy the full SHA dcec44fView commit details -
Set back the default behavior and change the configuration builder: s…
…et TrackMergeTarget to true for the develop branch.
Configuration menu - View commit details
-
Copy full SHA for eac6f01 - Browse repository at this point
Copy the full SHA eac6f01View commit details -
Fix WhenPreventIncrementOfMergedBranchVersionIsSetToFalseForDevelopCo…
…mmitsSinceVersionSourceShouldNotGoDownWhenMergingHotfixToDevelop test
Configuration menu - View commit details
-
Copy full SHA for 8f09a85 - Browse repository at this point
Copy the full SHA 8f09a85View commit details
Commits on Sep 12, 2022
-
Add ConfigBuilder to make it easier in tests to create configuration …
…instances. In advance add a overload to specify the initial branch name for the empty repository. Last but not least the logic in BaseVersionCalculator has been adapted: If the maximal version has no pre-release tag defined than we want to determine just the latest previous base source which are not comming from pre-release tag.
Configuration menu - View commit details
-
Copy full SHA for c62053b - Browse repository at this point
Copy the full SHA c62053bView commit details -
Create test for discussion: Prevent decrementation of versions on the…
… develop branch GitTools#3177
Configuration menu - View commit details
-
Copy full SHA for 3c74141 - Browse repository at this point
Copy the full SHA 3c74141View commit details
Commits on Sep 13, 2022
-
Modify PreventDecrementationOfVersionsOnTheDevelopBranch and remove T…
…rackMergeTarget functionality.
Configuration menu - View commit details
-
Copy full SHA for 937f761 - Browse repository at this point
Copy the full SHA 937f761View commit details
Commits on Sep 15, 2022
-
The way I'm calculating the effective configuration for each base ver…
…sion strategy implementation is highly recursive and works with inheritance from one branch configuration to another. This makes it highly configurable and we can support every workflow on the world and all workflows which are created in the future. Please notice the BranchConfigurationCalculator is not really used anymore.
Configuration menu - View commit details
-
Copy full SHA for befa745 - Browse repository at this point
Copy the full SHA befa745View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccb9f1f - Browse repository at this point
Copy the full SHA ccb9f1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55c899d - Browse repository at this point
Copy the full SHA 55c899dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f226d4 - Browse repository at this point
Copy the full SHA 8f226d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e29b80 - Browse repository at this point
Copy the full SHA 4e29b80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f12b5b - Browse repository at this point
Copy the full SHA 9f12b5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3110909 - Browse repository at this point
Copy the full SHA 3110909View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33dc540 - Browse repository at this point
Copy the full SHA 33dc540View commit details
Commits on Sep 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for de573a5 - Browse repository at this point
Copy the full SHA de573a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9471d9 - Browse repository at this point
Copy the full SHA a9471d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39b1abc - Browse repository at this point
Copy the full SHA 39b1abcView commit details
Commits on Sep 17, 2022
-
Move this logic to the class BaseVersionCalculator and change the int…
…erface of IVersionStrategy to be able to pass in the effective configuration.
Configuration menu - View commit details
-
Copy full SHA for 28a9d2b - Browse repository at this point
Copy the full SHA 28a9d2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f982607 - Browse repository at this point
Copy the full SHA f982607View commit details
Commits on Sep 18, 2022
-
Introduce the concept of fallback and unkown branch configuration. Wh…
…ich are conceptional not the same. Create additional tests for EffectiveBranchConfigurationFinderTests. In advance the ContinuousDeploymentTestScenarios integration test class has been added.
Configuration menu - View commit details
-
Copy full SHA for 7c585f2 - Browse repository at this point
Copy the full SHA 7c585f2View commit details -
Mastering the integration tests CreatingAFeatureBranchFromAReleaseBra…
…nch and ContinuousDeploymentTestScenarios.
Configuration menu - View commit details
-
Copy full SHA for da04d3f - Browse repository at this point
Copy the full SHA da04d3fView commit details -
Create a new EffectiveBranchConfiguration class which contains the Br…
…anch and the EffectiveConfiguration values. In advance this properties are now present in the NextVersion class to be prepaired to get rid of the Configuration property in the GitVersionContext class. No business logic has been changed in this commit.
Configuration menu - View commit details
-
Copy full SHA for 4475e05 - Browse repository at this point
Copy the full SHA 4475e05View commit details -
Fuse the BaseVersionCalculator with the NextVersionCalculator. No bus…
…iness logic changed.
Configuration menu - View commit details
-
Copy full SHA for e43dbf7 - Browse repository at this point
Copy the full SHA e43dbf7View commit details -
Finally I have changed all calls to GitVersionContext::Configuration …
…and deleted this property. Therfore I need to pass the NextVersion class out of NextVersionCalculator. Normally the SemanticVersion should be enough. But magic happens in the VariableProvider so that's why the effective configuration of the calculated version is necessary as well. Just refactoring no business logic changed.
Configuration menu - View commit details
-
Copy full SHA for 2531495 - Browse repository at this point
Copy the full SHA 2531495View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4095244 - Browse repository at this point
Copy the full SHA 4095244View commit details
Commits on Sep 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 260ee92 - Browse repository at this point
Copy the full SHA 260ee92View commit details -
EffectiveBranchConfigurationFinder public and remove one integration …
…test which was a duplicate.
Configuration menu - View commit details
-
Copy full SHA for 75f4c37 - Browse repository at this point
Copy the full SHA 75f4c37View commit details
Commits on Sep 20, 2022
-
Rename GetTargetBranches to GetSourceBranches. Fix some warnings and …
…document the obsolete code. Remove unused method in RepositoryStore. No business logic changed.
Configuration menu - View commit details
-
Copy full SHA for c6945fc - Browse repository at this point
Copy the full SHA c6945fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e73c92f - Browse repository at this point
Copy the full SHA e73c92fView commit details -
Move tests aspects from GitVersionContextTests to EffectiveBranchConf…
…igurationFinderTests
Configuration menu - View commit details
-
Copy full SHA for 6a69dce - Browse repository at this point
Copy the full SHA 6a69dceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 043264c - Browse repository at this point
Copy the full SHA 043264cView commit details -
Re comment tests in NextVersionCalculatorTests, MergeMessageBaseVersi…
…onStrategyTests and ConfigNextVersionBaseVersionStrategyTests.
Configuration menu - View commit details
-
Copy full SHA for 8f8e665 - Browse repository at this point
Copy the full SHA 8f8e665View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c9e3cf - Browse repository at this point
Copy the full SHA 1c9e3cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45cf14f - Browse repository at this point
Copy the full SHA 45cf14fView commit details
Commits on Sep 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8e1670f - Browse repository at this point
Copy the full SHA 8e1670fView commit details
Commits on Oct 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1041d07 - Browse repository at this point
Copy the full SHA 1041d07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5af8026 - Browse repository at this point
Copy the full SHA 5af8026View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9cf015 - Browse repository at this point
Copy the full SHA b9cf015View commit details
Commits on Oct 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 016d5a7 - Browse repository at this point
Copy the full SHA 016d5a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f062817 - Browse repository at this point
Copy the full SHA f062817View commit details
Commits on Oct 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a5f3d5e - Browse repository at this point
Copy the full SHA a5f3d5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74db309 - Browse repository at this point
Copy the full SHA 74db309View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2425546 - Browse repository at this point
Copy the full SHA 2425546View commit details
Commits on Oct 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2ba1989 - Browse repository at this point
Copy the full SHA 2ba1989View commit details -
Merge branch 'feature/3101' of https://github.com/HHobeck/GitVersion …
…into feature/3101
Configuration menu - View commit details
-
Copy full SHA for 0080e73 - Browse repository at this point
Copy the full SHA 0080e73View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff6f27f - Browse repository at this point
Copy the full SHA ff6f27fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 061c06e - Browse repository at this point
Copy the full SHA 061c06eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f0309b - Browse repository at this point
Copy the full SHA 7f0309bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc2e75d - Browse repository at this point
Copy the full SHA fc2e75dView commit details -
Merge branch 'feature/3101' of https://github.com/HHobeck/GitVersion …
…into feature/3101
Configuration menu - View commit details
-
Copy full SHA for 42da619 - Browse repository at this point
Copy the full SHA 42da619View commit details
Commits on Oct 6, 2022
-
Removing default values from hotfix branch configuration which should…
… be inherited from parent.
Configuration menu - View commit details
-
Copy full SHA for f39b551 - Browse repository at this point
Copy the full SHA f39b551View commit details
Commits on Oct 7, 2022
-
Remove FixTheBaseVersionSourceOfMergeMessageStrategyIfReleaseBranchWa…
…sMergedAndDeleted in NextVersionCalculator and move business logic to MergeMessageVersionStrategy class.
Configuration menu - View commit details
-
Copy full SHA for 94e2127 - Browse repository at this point
Copy the full SHA 94e2127View commit details
Commits on Oct 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for af1bf3f - Browse repository at this point
Copy the full SHA af1bf3fView commit details
Commits on Oct 11, 2022
-
Make the effective configuration tag not nullable. Default value for …
…tag will be present only on fallback branch configuration settings.
Configuration menu - View commit details
-
Copy full SHA for 6bd49cd - Browse repository at this point
Copy the full SHA 6bd49cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a405c6 - Browse repository at this point
Copy the full SHA 4a405c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 410c92e - Browse repository at this point
Copy the full SHA 410c92eView commit details -
Merge branch 'feature/3101' of https://github.com/HHobeck/GitVersion …
…into feature/3101
Configuration menu - View commit details
-
Copy full SHA for f24f235 - Browse repository at this point
Copy the full SHA f24f235View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77095ac - Browse repository at this point
Copy the full SHA 77095acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 32b0398 - Browse repository at this point
Copy the full SHA 32b0398View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3971272 - Browse repository at this point
Copy the full SHA 3971272View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0800edf - Browse repository at this point
Copy the full SHA 0800edfView commit details -
Co-authored-by: Asbjørn Ulsberg <asbjorn@ulsberg.no>
Configuration menu - View commit details
-
Copy full SHA for 1397f03 - Browse repository at this point
Copy the full SHA 1397f03View commit details