Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Remove legacy version variables and related configuration options in v6 #2325

Closed
asbjornu opened this issue Jun 12, 2020 · 2 comments · Fixed by #3130
Closed

[Improvement] Remove legacy version variables and related configuration options in v6 #2325

asbjornu opened this issue Jun 12, 2020 · 2 comments · Fixed by #3130
Labels
breaking change
Milestone
6.0.0-alpha.1

Comments

@asbjornu
Copy link
Member

We currently have quite a few version variables and related configuration options that are tailored towards sytems that don't support SemVer 2.0, such as LegacySemVerPadding, BuildMetaDataPadding, CommitsSinceVersionSourcePadding, etc.

We should remove these in v6, at least from Core. If pepole still need these, we should look into adding them through an extension to the Core somehow.
@asbjornu asbjornu added this to the 6.0.0 milestone Jun 12, 2020
@stale
Copy link

stale bot commented Sep 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 10, 2020
@asbjornu asbjornu removed the stale label Sep 10, 2020
arturcic added a commit to arturcic/GitVersion that referenced this issue May 26, 2022
@arturcic
GitTools#2325 - remove legacy variables
6eb3a8e
arturcic added a commit that referenced this issue May 26, 2022
@arturcic
#2325 - remove legacy variables
3f0e175
arturcic added a commit to arturcic/GitVersion that referenced this issue May 27, 2022
@arturcic
GitTools#2325 - remove legacy variables
6384e14
arturcic added a commit to arturcic/GitVersion that referenced this issue May 27, 2022
@arturcic
GitTools#2325 - remove legacy variables
80ba888
arturcic added a commit to arturcic/GitVersion that referenced this issue May 27, 2022
@arturcic
GitTools#2325 - remove legacy variables
9fb6945
arturcic added a commit to arturcic/GitVersion that referenced this issue May 27, 2022
@arturcic
GitTools#2325 - remove legacy variables
8d88cfd
arturcic added a commit to arturcic/GitVersion that referenced this issue May 27, 2022
@arturcic
GitTools#2325 - enable macos tests
090f308
arturcic added a commit to arturcic/GitVersion that referenced this issue May 27, 2022
@arturcic
GitTools#2325 - remove legacy variables
a298d02
@arturcic arturcic mentioned this issue May 28, 2022
Merged
arturcic added a commit to arturcic/GitVersion that referenced this issue May 28, 2022
@arturcic
GitTools#2325 - remove legacy variables
00ada4f
arturcic added a commit that referenced this issue May 31, 2022
@arturcic
#2325 - remove legacy variables
5b8837a
@arturcic arturcic modified the milestones: 6.x, 6.0.0-alpha.1 Dec 22, 2022
@arturcic
Copy link
Member

🎉 This issue has been resolved in version 6.0.0 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

@arturcic arturcic mentioned this issue Jul 25, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
6.0.0-alpha.1
Development

Successfully merging a pull request may close this issue.

#2325 - remove legacy variables arturcic/GitVersion
2 participants
@asbjornu @arturcic