Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.14] Update MergeRequests::all to use millisecond precision #787

Merged
merged 8 commits into from
Mar 17, 2024

Conversation

janedbal
Copy link
Contributor

We are iteratively fetching new MRs via:

updated_after=2023-01-24T18:05:25.801Z
&sort=asc
&order_by=updated_at

And there is more than 100 MR updated within a second. Current implementation causes the same MRs to be analysed again every time. But the API seems to support microsecond precision, so this should fix it.

@GrahamCampbell GrahamCampbell changed the base branch from 11.13 to 11.14 December 14, 2023 12:23
- 2023-01-24T18:05:25.801Z works
- 2023-01-24T18:05:25.801+00:00 does not work
@janedbal
Copy link
Contributor Author

Adjusted the formatting:

  • 2023-01-24T18:05:25.801Z works
  • 2023-01-24T18:05:25.801+00:00 does not work

@GrahamCampbell
Copy link
Member

This uses millisecond precision, not microsecond?

@janedbal janedbal changed the title MergeRequests::all: send datetimes with microsecond precision MergeRequests::all: send datetimes with millisecond precision Dec 14, 2023
@janedbal
Copy link
Contributor Author

janedbal commented Dec 14, 2023

Yes, adjusted title. GitLab API returns datetimes with milliseconds, not micro. So that is probably the best precision we can use.

@janedbal
Copy link
Contributor Author

@GrahamCampbell any needed changes here?

@janedbal
Copy link
Contributor Author

ping

@GrahamCampbell GrahamCampbell changed the title MergeRequests::all: send datetimes with millisecond precision [11.14] Update MergeRequests::all to use millisecond precision Mar 17, 2024
@GrahamCampbell GrahamCampbell merged commit 7d52be1 into GitLabPHP:11.14 Mar 17, 2024
1 check passed
@GrahamCampbell
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants