Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize template #41

Merged
merged 13 commits into from
Feb 16, 2024
Merged

Modernize template #41

merged 13 commits into from
Feb 16, 2024

Conversation

LKajan
Copy link
Collaborator

@LKajan LKajan commented Jan 10, 2024

Main changes:

  • Change to use Ruff as a linter and formatter
  • Fixes deprecated VS Code settings

Resolves #29

@LKajan LKajan force-pushed the modernize-template branch 2 times, most recently from f127ed4 to 1e4e9a7 Compare January 10, 2024 10:37
@JuhoErvasti
Copy link
Contributor

Not sure if this is caused by anything in the implementation itself, but on Ubuntu in VS Code mypy is reporting missing library stubs in the plugin.py file for all imports from the qgis package.

Skipping analyzing "qgis.core": module is installed, but missing library stubs or py.typed markerMypy[import-untyped]

Similar error in build.py:

Cannot find implementation or library stub for module named "qgis_plugin_tools.infrastructure.plugin_maker"

Copy link
Contributor

@nmaarnio nmaarnio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I might have missed something in my testing since I did not get the same error as @JuhoErvasti

@LKajan LKajan force-pushed the modernize-template branch 2 times, most recently from 00388b9 to 96ef15f Compare February 12, 2024 09:58
@LKajan
Copy link
Collaborator Author

LKajan commented Feb 16, 2024

Not sure if this is caused by anything in the implementation itself, but on Ubuntu in VS Code mypy is reporting missing library stubs in the plugin.py file for all imports from the qgis package.

Skipping analyzing "qgis.core": module is installed, but missing library stubs or py.typed markerMypy[import-untyped]

Similar error in build.py:

Cannot find implementation or library stub for module named "qgis_plugin_tools.infrastructure.plugin_maker"

I ignored those missing type errors on qgis and osgeo package. And for qgis_plugin_tools all typing errors completly.

@LKajan LKajan merged commit d9db60e into main Feb 16, 2024
16 checks passed
@LKajan LKajan deleted the modernize-template branch February 16, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More flake8 plugins
3 participants