-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize template #41
Conversation
f127ed4
to
1e4e9a7
Compare
Not sure if this is caused by anything in the implementation itself, but on Ubuntu in VS Code mypy is reporting missing library stubs in the plugin.py file for all imports from the qgis package.
Similar error in build.py:
|
1e4e9a7
to
287ab11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although I might have missed something in my testing since I did not get the same error as @JuhoErvasti
...}}/{{cookiecutter.plugin_package}}/{{cookiecutter.plugin_package}}_processing/provider.py.j2
Outdated
Show resolved
Hide resolved
00388b9
to
96ef15f
Compare
Python extension in VsCode now ships better Pylance language server.
By default Ruff return 0 when formatting successfully. --check flag is mandatory to return non zero exit code when there is something to format.
96ef15f
to
fa6ebb9
Compare
9809bd0
to
f1db8a0
Compare
I ignored those missing type errors on qgis and osgeo package. And for qgis_plugin_tools all typing errors completly. |
Main changes:
Resolves #29