Admissions: fix secondParent checkbox default value

GibbonEdu · May 23, 2024 · b0d3f8b · b0d3f8b
1 parent d27a6f6
commit b0d3f8b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.txt b/CHANGELOG.txt
@@ -31,6 +31,7 @@ v28.0.00
     Tweaks & Additions
 
     Bug Fixes
+        Admissions: fix "Do not include a second parent" being accidentally checked by default
 
 v27.0.00
 --------

diff --git a/modules/Admissions/applicationForm.php b/modules/Admissions/applicationForm.php
@@ -123,7 +123,7 @@
 
     // Load values from the form data storage
     $values = $formData->getData();
-    $values['secondParent'] = $formData->get('secondParent') ?? ($formData->has('parent2surname') ? 'Yes' : 'No');
+    $values['secondParent'] = $formData->get('secondParent') ?? ($formData->has('parent2surname') ? 'No' : 'Yes');
 
     // Is the current application incomplete?
     $incomplete = empty($formData->getStatus()) || $formData->getStatus() == 'Incomplete';