fix: downgrade react-markdown to v8 that supports React version < v18 #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v11 #2461 +/- ##
===============================================
- Coverage 85.51% 85.50% -0.02%
===============================================
Files 393 393
Lines 9127 9125 -2
Branches 2492 2357 -135
===============================================
- Hits 7805 7802 -3
- Misses 924 1121 +197
+ Partials 398 202 -196 ☔ View full report in Codecov by Sentry. |
oliverlaz
reviewed
Aug 2, 2024
Comment on lines
8
to
9
| if (index === null || typeof index === 'undefined' || index === 0) return; | ||
| if (parent === null || typeof parent === 'undefined') return; |
There was a problem hiding this comment.
Can we simplify this to if (!index || !parent) return;?
oliverlaz
approved these changes
Aug 5, 2024
|
🎉 This PR is included in version 11.23.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
## [12.0.0-rc.8](v12.0.0-rc.7...v12.0.0-rc.8) (2024-08-15) ### Bug Fixes * **deps:** drop remark-gfm version ([#2471](#2471)) ([1b359f7](1b359f7)) * do not rerender on client options update ([#2465](#2465)) ([81f33ba](81f33ba)) * do not rerender on client options update ([#2465](#2465)) ([3899352](3899352)) * downgrade react-markdown to v8 that supports React version < v18 ([#2461](#2461)) ([5e6fea0](5e6fea0)) * forward StreamChat constructor options via useCreateChatClient ([#2463](#2463)) ([310835d](310835d)) * prevent ChannelPreviews with duplicate keys ([1a075ad](1a075ad)) * prevent including own user in read count displayed in MessageStatus ([#2459](#2459)) ([061d1a3](061d1a3)) * provide both browser and node cjs bundles ([#2457](#2457)) ([273ea2a](273ea2a)) ### Chores * **deps:** remove unused isomorphic-ws from dependencies ([853bd8b](853bd8b))
|
🎉 This PR is included in version 12.0.0-rc.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
fix #2455
fix #2234
🛠 Implementation details
Only react-markdown was downgraded while the libraries used to create remark and rehype plugins have not. Custom rehype or remark plugins using
visitfunction from the libraryunist-util-visitwill have to check theindexandparentarguments of theVisitorfunction fornullandundefined.