fix: allow to pass minRows prop to MessageInput #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v11 #2411 +/- ##
============================================
Coverage 85.33% 85.33%
============================================
Files 392 392
Lines 9029 9029
Branches 2323 2323
============================================
Hits 7705 7705
Misses 1116 1116
Partials 208 208 ☔ View full report in Codecov by Sentry. |
|
Size Change: +404 B (+0.02%) Total Size: 2.05 MB
ℹ️ View Unchanged
|
myandrienko
approved these changes
Jun 11, 2024
arnautov-anton
approved these changes
Jun 11, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
## [11.21.0](v11.20.0...v11.21.0) (2024-06-14) ### Bug Fixes * allow to pass minRows prop to MessageInput ([#2411](#2411)) ([e6bfd40](e6bfd40)) * memoize addNotification function provided by Channel component ([#2423](#2423)) ([b3734a4](b3734a4)) ### Features * allow to configure date and time format over i18n ([#2419](#2419)) ([cb09dc1](cb09dc1))
|
🎉 This PR is included in version 11.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Allow to specify
TextareaminRowsviaMessageInputProps.Depends on GetStream/stream-chat-css#297
🛠 Implementation details
The
MessageInputhas a propmaxRowsthat is just forwarded down toTeaxtareafrom react-textarea-autosize. ThroughadditiontalTextareaProps, it is possible to forwardminRowstoo. Seems like the original creator that typed that prop did not realize that all the props recognized byTeaxtareaare actually passed toTeaxtarea`.To make the behavior consistent I expose new prop -
minRows- onMessageInputProps.