fix: prevent showing link previews in AttachmentPreviewList #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2398 +/- ##
==========================================
+ Coverage 85.28% 85.31% +0.02%
==========================================
Files 392 392
Lines 9025 9027 +2
Branches 2320 2322 +2
==========================================
+ Hits 7697 7701 +4
+ Misses 1120 1118 -2
Partials 208 208 ☔ View full report in Codecov by Sentry. |
|
Size Change: +133 B (+0.01%) Total Size: 2.15 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
May 22, 2024
MartinCupela
deleted the
fix/no-show-link-preview-by-attachment-preview-list
branch
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
## [11.19.0](v11.18.1...v11.19.0) (2024-05-23) ### Bug Fixes * fix aria label translations for Portuguese ([28b6dfd](28b6dfd)) * prevent loading more non-existent thread replies ([#2399](#2399)) ([f2ed479](f2ed479)) * prevent showing link previews in AttachmentPreviewList ([#2398](#2398)) ([cf24894](cf24894)) ### Features * adopt new queryReactions endpoint ([#2388](#2388)) ([d6ca4ef](d6ca4ef))
|
🎉 This PR is included in version 11.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Prevent showing link previews in AttachmentPreviewList:
🛠 Implementation details
Link previews are not filtered out of
attachmentsarray inMessageInputstate. Therefore:attachmentsand no uploads, do not showAttachmentPreviewListattachments, showAttachmentPreviewListwithout attachments representing link previews. The link previews are rendered with another component.Out of scope
Tests to cover these requirements are just drafted in todo as the whole
MessageInput.test.jstests only v1 components. These tests will be added to #2394 (added with commit ef5e46b)