feat: voice recording message attachment #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cording waveform downsampling
MartinCupela
requested review from
oliverlaz,
myandrienko,
szuperaz and
arnautov-anton
MartinCupela
changed the title
MartinCupela
commented
Mar 5, 2024
| * @param data | ||
| * @param targetOutputSize | ||
| */ | ||
| export function downSample(data: number[], targetOutputSize: number): number[] { |
There was a problem hiding this comment.
Downsampling algorithm used does not use mean to reduce the data, but it rather selects a value that represents the biggest difference compared to the previous and next bucket.
oliverlaz
reviewed
Mar 5, 2024
docusaurus/docs/React/components/message-components/attachment/voice-recording.mdx
Outdated
Show resolved
Hide resolved
myandrienko
reviewed
Mar 6, 2024
myandrienko
approved these changes
Mar 6, 2024
oliverlaz
approved these changes
Mar 7, 2024
docusaurus/docs/React/components/message-components/attachment/voice-recording.mdx
Outdated
Show resolved
Hide resolved
docusaurus/docs/React/components/message-components/attachment/voice-recording.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Anton Arnautov <43254280+arnautov-anton@users.noreply.github.com>
|
Size Change: +15.2 kB (+1%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2311 +/- ##
==========================================
+ Coverage 84.84% 84.99% +0.14%
==========================================
Files 345 351 +6
Lines 7729 7904 +175
Branches 2146 2188 +42
==========================================
+ Hits 6558 6718 +160
- Misses 823 834 +11
- Partials 348 352 +4 ☔ View full report in Codecov by Sentry. |
oliverlaz
reviewed
Mar 7, 2024
|
🎉 This PR is included in version 11.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Provide new attachment type -
"voiceRecording". The attachment widget allows to display the recording in a quoted reply or to reproduce the recorded audio. The player allows toggling playback speed and navigation by clicking and dragging.Depends on:
🎨 UI Changes
Please see the docs assets.