Pass groupStyles through VirtualizedMessageList #2214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 |
|
Hey @TaylorBeeston, thank you for the submission. We will pick it up from here as there are tests missing :) |
MartinCupela
force-pushed
the
master
branch
2 times, most recently
from
e866edb
to
78d643f
Compare
|
🎉 This issue has been resolved in version 11.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
🎯 Goal
Describe why we are making this change
We are trying to switch to
VirtualizedMessageListand found that our customgroupStylesstopped working!When I dug around, I found that the prop is simply not getting passed through.
🛠 Implementation details
Provide a description of the implementation
Inside of
messageRenderinVirtualizedMessageListComponents, I grab themessageGroupStylesobjectoff of the Virtuoso context, grab the
groupStylesstring that has been set for this message, thenadd it as the
groupStylesprop for theMesssagecomponent.🎨 UI Changes
Add relevant screenshots
I was having trouble getting this to build locally to get some screenshots =(
It would build fine, but I was getting errors about multiple versions of react when trying to link
the locally built package. I figured that's probably more headache than it's worth so I thought I'd
just get this PR up!