Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add update options into a couple places for channel #821

Merged
merged 7 commits into from
Nov 25, 2021
Merged

Add update options into a couple places for channel #821

merged 7 commits into from
Nov 25, 2021

Conversation

ferhatelmas
Copy link
Contributor

@ferhatelmas ferhatelmas commented Nov 25, 2021 •
edited
Loading

No description provided.

@ferhatelmas ferhatelmas changed the title Add options into a couple places Add update options into a couple places for channel Nov 25, 2021
@ferhatelmas ferhatelmas marked this pull request as ready for review November 25, 2021 16:12
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2021 •
edited
Loading

Size Change: +364 B (0%)

Total Size: 264 kB

Filename Size Change
dist/browser.es.js 57.8 kB +94 B (0%)
dist/browser.full-bundle.min.js 31.2 kB +4 B (0%)
dist/browser.js 58.4 kB +86 B (0%)
dist/index.es.js 57.9 kB +94 B (0%)
dist/index.js 58.5 kB +86 B (0%)

compressed-size-action

mahboubii
mahboubii reviewed Nov 25, 2021
View reviewed changes
src/channel.ts Outdated Show resolved Hide resolved
mahboubii
mahboubii reviewed Nov 25, 2021
View reviewed changes
src/channel.ts Outdated Show resolved Hide resolved
src/channel.ts Outdated Show resolved Hide resolved
src/channel.ts Outdated Show resolved Hide resolved
src/channel.ts Outdated Show resolved Hide resolved
ferhatelmas and others added 5 commits November 25, 2021 17:26
@ferhatelmas
Update src/channel.ts
3b1aeac 
Co-authored-by: Amin Mahboubi <amin@getstream.io>
@ferhatelmas
Update src/channel.ts
e973d33 
Co-authored-by: Amin Mahboubi <amin@getstream.io>
@ferhatelmas
Update src/channel.ts
536bbbb 
Co-authored-by: Amin Mahboubi <amin@getstream.io>
@ferhatelmas
Update src/channel.ts
9668282 
Co-authored-by: Amin Mahboubi <amin@getstream.io>
@ferhatelmas
Update src/channel.ts
88783c2 
Co-authored-by: Amin Mahboubi <amin@getstream.io>
mahboubii
mahboubii previously approved these changes Nov 25, 2021
View reviewed changes
@mahboubii mahboubii merged commit 7b58eef into master Nov 25, 2021
@mahboubii mahboubii deleted the more-options branch November 25, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahboubii mahboubii mahboubii approved these changes

@AnatolyRugalev AnatolyRugalev Awaiting requested review from AnatolyRugalev

@gumuz gumuz Awaiting requested review from gumuz

@vini-btc vini-btc Awaiting requested review from vini-btc

@vishalnarkhede vishalnarkhede Awaiting requested review from vishalnarkhede vishalnarkhede is a code owner

@yaziine yaziine Awaiting requested review from yaziine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferhatelmas @mahboubii