Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend channel truncation params #815

Merged
merged 7 commits into from
Nov 25, 2021
Merged

Extend channel truncation params #815

merged 7 commits into from
Nov 25, 2021

Conversation

driver-devel
Copy link
Contributor

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

Changelog

  • Support system messages for the channel truncate action
  • Allow to specify custom truncated_at attribute

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2021 •
edited
Loading

Size Change: -13 B (0%)

Total Size: 263 kB

Filename Size Change
dist/browser.es.js 57.7 kB -5 B (0%)
dist/browser.js 58.3 kB -2 B (0%)
dist/index.es.js 57.7 kB -4 B (0%)
dist/index.js 58.4 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size Change
dist/browser.full-bundle.min.js 31.1 kB 0 B

compressed-size-action

@driver-devel driver-devel marked this pull request as ready for review November 24, 2021 11:11
mahboubii
mahboubii reviewed Nov 24, 2021
View reviewed changes
src/channel.ts Outdated Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
src/channel.ts Outdated Show resolved Hide resolved
src/channel.ts Outdated Show resolved Hide resolved
mahboubii
mahboubii reviewed Nov 24, 2021
View reviewed changes
src/channel.ts Outdated Show resolved Hide resolved
src/channel.ts Outdated Show resolved Hide resolved
src/channel.ts Outdated Show resolved Hide resolved
ferhatelmas
ferhatelmas approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaziine yaziine merged commit c27a999 into master Nov 25, 2021
@yaziine yaziine deleted the CHAT-2596/trunc-pt2 branch November 25, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhatelmas ferhatelmas ferhatelmas approved these changes

@mahboubii mahboubii mahboubii approved these changes

@AnatolyRugalev AnatolyRugalev Awaiting requested review from AnatolyRugalev

@gumuz gumuz Awaiting requested review from gumuz

@vini-btc vini-btc Awaiting requested review from vini-btc

@vishalnarkhede vishalnarkhede Awaiting requested review from vishalnarkhede vishalnarkhede is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@driver-devel @ferhatelmas @mahboubii @yaziine