Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHAT-1823] Add async deleteChannels endpoint #769

Merged
merged 5 commits into from
Oct 6, 2021
Merged

[CHAT-1823] Add async deleteChannels endpoint #769

merged 5 commits into from
Oct 6, 2021

Conversation

yaziine
Copy link
Contributor

@yaziine yaziine commented Sep 15, 2021

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2021 •
edited
Loading

Size Change: +875 B (0%)

Total Size: 252 kB

Filename Size Change
dist/browser.es.js 55.1 kB +209 B (0%)
dist/browser.full-bundle.min.js 30.1 kB +27 B (0%)
dist/browser.js 55.7 kB +215 B (0%)
dist/index.es.js 55.1 kB +210 B (0%)
dist/index.js 55.8 kB +214 B (0%)

compressed-size-action

@yaziine yaziine force-pushed the async-delete-channels branch 2 times, most recently from 44975d6 to c9d6a78 Compare September 28, 2021 11:33
ferhatelmas
ferhatelmas reviewed Oct 1, 2021
View reviewed changes
src/client.ts Outdated Show resolved Hide resolved
ferhatelmas
ferhatelmas reviewed Oct 1, 2021
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget updating PR title

@yaziine yaziine changed the title Add deleteChannels and getTask methods [CHAT-1823] Add deleteChannels and getTask methods Oct 6, 2021
mahboubii
mahboubii previously approved these changes Oct 6, 2021
View reviewed changes
src/client.ts Outdated Show resolved Hide resolved
@yaziine
Update src/client.ts
32ae16e 
Co-authored-by: Amin Mahboubi <amin@getstream.io>
ferhatelmas
ferhatelmas reviewed Oct 6, 2021
View reviewed changes
src/client.ts Outdated Show resolved Hide resolved
ferhatelmas
ferhatelmas reviewed Oct 6, 2021
View reviewed changes
src/client.ts Outdated Show resolved Hide resolved
ferhatelmas
ferhatelmas approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@ferhatelmas ferhatelmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferhatelmas ferhatelmas changed the title [CHAT-1823] Add deleteChannels and getTask methods [CHAT-1823] Add async deleteChannels endpoint Oct 6, 2021
@ferhatelmas ferhatelmas merged commit 668b3e5 into master Oct 6, 2021
@ferhatelmas ferhatelmas deleted the async-delete-channels branch October 6, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferhatelmas ferhatelmas ferhatelmas approved these changes

@mahboubii mahboubii mahboubii approved these changes

@AnatolyRugalev AnatolyRugalev Awaiting requested review from AnatolyRugalev

@gumuz gumuz Awaiting requested review from gumuz

@vishalnarkhede vishalnarkhede Awaiting requested review from vishalnarkhede vishalnarkhede is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaziine @ferhatelmas @mahboubii