Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/thread loading bug and message update bug #713

Merged
merged 15 commits into from
Jul 13, 2021

Conversation

nhannah
Copy link
Contributor

@nhannah nhannah commented Jul 8, 2021

Because the SDKs rely on the current message state to determine when and what they should reload there were multiple edge cases currently present that could cause issues with loading. Updates, and deletions to both messages and thread messages could add to the message list messages which were out of sync with the current desired state. These caused the loading logic to function incorrectly as it is dependent on the currently loaded state for pagination.

This situation also arose with messages in that are shown both in a thread and in the main channel. They would be loaded for the main channel but also added to the thread, these randomly added thread messages could cause the loading logic for threads to also get out of sync.

These fixes address these edge cases to keep a state more inline with that desired by the SDKs and users.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

Size Change: +1.83 kB (0%)

Total Size: 233 kB

Filename Size Change
dist/browser.es.js 50.7 kB +437 B (0%)
dist/browser.full-bundle.min.js 28.8 kB +96 B (0%)
dist/browser.js 51.3 kB +428 B (0%)
dist/index.es.js 50.8 kB +438 B (0%)
dist/index.js 51.4 kB +429 B (0%)

compressed-size-action

@AnatolyRugalev
Copy link
Contributor

AnatolyRugalev commented Jul 9, 2021

@nhannah we have upcoming changes regarding this exact problem from the backend, so let's not rush merging this as this may fix issue without SDK changes

Never mind, this is a different issue

vishalnarkhede
vishalnarkhede previously approved these changes Jul 13, 2021
Co-authored-by: Vishal Narkhede <vishalnarkhede.iitd@gmail.com>
@vishalnarkhede vishalnarkhede merged commit 86f30cd into master Jul 13, 2021
@vishalnarkhede vishalnarkhede deleted the fix/thread-loading-bug branch July 13, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants