[CJS3] client single instance #599
Conversation
|
Size Change: +2.11 kB (0%) Total Size: 216 kB
|
|
|
||
| expect(client1).to.equal(client2); | ||
| expect(client2.key).to.eql('key2'); | ||
| }); |
There was a problem hiding this comment.
Can we also add following scenario to unit-test?
const client1 = StreamChat.getInstance('key2');
await client1.setUser({ id: 'vishal });
const client2 = StreamChat.getInstance('key3'); // or key2
await client2.setUser({ id: 'vishal });There was a problem hiding this comment.
Currently if you call setUser twice, it throws following error:
'Use client.disconnect() before trying to connect as a different user. connectUser was called twice.'
But I think we should allow it if current user is same as id provided to setUser
There was a problem hiding this comment.
pushed a test d2fcfc3
There was a problem hiding this comment.
@vishalnarkhede yea I actually put a comment in the PR description about this which is out of the scope of this PR. This is still an integration mistake but we can make it easier for users by not throwing error
There was a problem hiding this comment.
Ahaa ... sorry missed it!!
Can we add it though ... seems like a simple check
There was a problem hiding this comment.
yea totally will open another PR on top of this one
Unfortunately Lots of TS boilerplates due to generics.
Potential Future improvements:
connectUsercan return the resolved promise for the second call instead of throwing an error if the user id in the token remains the same