-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flag options #462
Flag options #462
Conversation
Size Change: +325 B (0%) Total Size: 197 kB
ℹ️ View Unchanged
|
export type FlagMessageOptions<UserType = UnknownType> = { | ||
client_id?: string; | ||
connection_id?: string; | ||
created_by?: string; | ||
target_message_id?: string; | ||
target_user_id?: string; | ||
user?: UserResponse<UserType>; | ||
user_id?: string; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this specific type overcomplicates the functions for users, the only thing that is really needed here is user_id?: string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and at some point we should probably add documentation about the different params used server-side. We currently have a tiny Server Side API docs section but it misses most of these use cases.
closes #314