fix types for channel.sendReaction #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarbugli
reviewed
Jan 28, 2020
types/stream-chat/index.d.ts
Outdated
| @@ -113,6 +113,9 @@ export interface Reaction { | |||
| [propName: string]: any; | |||
| } | |||
|
|
|||
| export interface ReactionRequest { | |||
| type: string; | |||
There was a problem hiding this comment.
reactions have more fields, @bogdan-d please help here :)
There was a problem hiding this comment.
This is just for sending a reaction though. I was working on the typescript stuff and it was failing because we reused the Reaction response object for this.
There was a problem hiding this comment.
@jaapbakker88 Which properties of Reaction were breaking? I can see message_id, user as required properties on Reaction type. They are used for request using server side token. So maybe we can make them optional!!
There was a problem hiding this comment.
@vishalnarkhede updated to use only the type as a required property. It was indeed breaking on the rest.
|
@vishalnarkhede updated this |
|
Looks good now :) |
vishalnarkhede
approved these changes
Feb 4, 2020
kevinnath1007
pushed a commit
to kevinnath1007/stream-chat-js
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request