Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: polls rewrite #1373

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft

feat: polls rewrite #1373

wants to merge 32 commits into from
+606 −212

Conversation

MartinCupela
Copy link
Contributor

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

Changelog

MartinCupela and others added 30 commits September 18, 2024 11:05
@MartinCupela
feat: extract PollAnswer type from PollVote type
d4424ed
@MartinCupela
fix: populate missing generics for PollAnswer
b43297c
@MartinCupela
fix: populate missing generics for QueryPollsResponse
75f2b60
@MartinCupela
refactor: simplify PollAnswer type
9302884
@MartinCupela
feat: add client.queryPollAnswers method
28edc51
@MartinCupela
fix: remove channel and cid from PollResponse
dfa8f47
@MartinCupela
fix: fix poll types
a38f393
@MartinCupela
refactor: keep exports ordered in alphabetic order
fe845db
@MartinCupela
fix: add missing StreamChatGenerics to poll types in client method de…
7a523c6 
…clarations
@MartinCupela
style: run lint
4151673
@MartinCupela
feat: add Poll class
a03a0c7
@MartinCupela
fix: remove paginator from index
5f0df10
@MartinCupela
feat: add Poll.queryPollAnswers & Poll.queryOptionVotes
c58d02b
@MartinCupela
fix: prevent recursion on poll.data getter
7d0206a
@MartinCupela
fix: remove poll event handlers in channel state
184cb80
@isekovanic
feat: poll_manager initial impl
aece207
@MartinCupela
style: fix lint issues
1dfe2fe
@MartinCupela
feat: add maxVotedOptionIds, ownVotesByOptionId, ownAnswer to PollState
33cf859
@MartinCupela
style: fix lint issues
04efc24
@MartinCupela
fix: prevent executing poll event listener for other polls & subscrib…
51ac4f6 
…e to vote_changed + vote_removed
@MartinCupela
fix: remove previous own answers on vote changed
33fd469
@MartinCupela
fix: make sure own votes do not contain answers
a3dacd0
@MartinCupela
fix: reassign own votes on vote change
9a53d6b
@MartinCupela
fix: override own votes on poll.vote_changed event
2c18517
@MartinCupela
fix: initiate ownAnswer in Poll state when initiating Poll instance
6cb6cc3
@isekovanic
fix: minor issues and extract id from reactive state
f6b8b6d
@MartinCupela
fix: convert Poll methods to array functions
17a674f
@MartinCupela
Merge remote-tracking branch 'origin/feat/polls-rewrite' into feat/po…
49b420f 
…lls-rewrite
@MartinCupela
fix: do not use poll.data.id
25a8ee3
@MartinCupela
fix: on poll WS event update partially the state with PollEnrichData …
eabf3e5 
…or PollData only
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

Size Change: +17.6 kB (+4.12%)

Total Size: 445 kB

Filename Size Change
dist/browser.es.js 96.7 kB +4.03 kB (+4.35%)
dist/browser.full-bundle.min.js 55.5 kB +1.35 kB (+2.5%)
dist/browser.js 97.9 kB +4.1 kB (+4.37%)
dist/index.es.js 96.7 kB +4.03 kB (+4.35%)
dist/index.js 97.9 kB +4.1 kB (+4.37%)

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalnarkhede vishalnarkhede Awaiting requested review from vishalnarkhede vishalnarkhede will be requested when the pull request is marked ready for review vishalnarkhede is a code owner

@santhoshvai santhoshvai Awaiting requested review from santhoshvai santhoshvai will be requested when the pull request is marked ready for review santhoshvai is a code owner

@khushal87 khushal87 Awaiting requested review from khushal87 khushal87 will be requested when the pull request is marked ready for review khushal87 is a code owner

@szuperaz szuperaz Awaiting requested review from szuperaz szuperaz will be requested when the pull request is marked ready for review szuperaz is a code owner

@oliverlaz oliverlaz Awaiting requested review from oliverlaz oliverlaz will be requested when the pull request is marked ready for review oliverlaz is a code owner

@arnautov-anton arnautov-anton Awaiting requested review from arnautov-anton arnautov-anton will be requested when the pull request is marked ready for review arnautov-anton is a code owner

@myandrienko myandrienko Awaiting requested review from myandrienko myandrienko will be requested when the pull request is marked ready for review myandrienko is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinCupela @isekovanic