Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle notification.mark_unread #1208

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

MartinCupela
Copy link
Contributor

Description of the changes, What, Why and How?

Upon receiving the new notification.mark_unread event update:

  • channel read state for "author" of the event
  • update channel's unreadCount property

A new property added to the ChannelReadStatus is first_unread_message_id which basically is an indicator whether the channel has been marked unread. The property is undefined for message.new events.

With the above state updates, the SDK can implement the feature of marking messages in a channel as unread.

Copy link
Contributor

Size Change: +607 B (0%)

Total Size: 328 kB

Filename Size Change
dist/browser.es.js 70.6 kB +95 B (0%)
dist/browser.full-bundle.min.js 43.9 kB +232 B (+1%)
dist/browser.js 71.6 kB +90 B (0%)
dist/index.es.js 70.6 kB +100 B (0%)
dist/index.js 71.6 kB +90 B (0%)

compressed-size-action

@MartinCupela MartinCupela merged commit 4d73838 into master Jan 12, 2024
5 of 6 checks passed
@MartinCupela MartinCupela deleted the feat/handle-notification-mark-unread branch January 12, 2024 11:34
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
This was referenced Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants