Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle getting channel by members with channel id explicitly undefined #1169

Merged

Conversation

MartinCupela
Copy link
Contributor

CLA

  • [ X ] Code changes are tested

Description of the changes, What, Why and How?

The client.channel() method did not handle correctly client.channel(type, undefined, channelData) calls. Instead of trying to find channel by members it directly returned a brand new Channel instance. Also it tried to get channel by id, if id was explicitly set to undefined.

@github-actions
Copy link
Contributor

Size Change: +217 B (0%)

Total Size: 318 kB

Filename Size Change
dist/browser.es.js 69.6 kB +49 B (0%)
dist/browser.full-bundle.min.js 37.7 kB +24 B (0%)
dist/browser.js 70.6 kB +49 B (0%)
dist/index.es.js 69.7 kB +50 B (0%)
dist/index.js 70.6 kB +45 B (0%)

compressed-size-action

@MartinCupela MartinCupela merged commit a721b59 into master Sep 18, 2023
5 of 6 checks passed
@MartinCupela MartinCupela deleted the fix/get-channel-by-members-on-undefined-channel-id branch September 18, 2023 14:17
@github-actions github-actions bot mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants