fix: prevent truncating message timestamps when updating references to deleted quoted message #1141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
When
message.deleted
event was delivered, the client code invokedchannelState.removeQuotedMessageReferences(event.message);
. This function was convertingcreated_at, pinned_at, updated_at
values of each quoting message to string usingtoString()
method. That lead to truncation of milliseconds from each timestamp. Later the truncated timestamps distorted the decision logic inChannelState._addToMessageList()
in the following way,message.updated
carriedcreated_at
timestamp with millisecondscreated_at
timestamp without millisecondsaddIfDoesNotExist
param forChannelState._addToMessageList()
is set to false when handlingmessage.updated
eventsSolution is not to truncate the message timestamps, when updating references to deleted quoted message.