Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set DisableInitialHostLookup to false #170

Merged
merged 2 commits into from
May 24, 2024
Merged

fix: set DisableInitialHostLookup to false #170

merged 2 commits into from
May 24, 2024

Conversation

CallumNZ
Copy link
Contributor

@CallumNZ CallumNZ commented May 24, 2024

In an effort to prevent the intermittent error seen in https://github.com/GeoNet/tickets/issues/15591

Other relevant tickets:
apache/cassandra-gocql-driver#1721
apache/cassandra-gocql-driver#915

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Insert check list here if needed.

@CallumNZ CallumNZ requested review from junghao and bpeng and removed request for junghao May 24, 2024 00:59
bpeng
bpeng previously approved these changes May 24, 2024
Copy link
Contributor

@bpeng bpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

In an effort to prevent the intermittent error seen in GeoNet/tickets#15591
Makes session creation much faster, and matches AWS Keyspaces documentation
@sue-h-gns sue-h-gns merged commit 89e8bae into main May 24, 2024
7 checks passed
@sue-h-gns sue-h-gns deleted the gocqlBug branch May 24, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants