-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IIB2019018 #4
base: master
Are you sure you want to change the base?
IIB2019018 #4
Conversation
I hope all the content has reached. This was my first PR.
@Niftyy please take a look at this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at your directory structure.
@thesmallstar sorry, i didn't get you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix directory structure, take a look at previous submissions. You have to add only one folder inside Task - 1 which contains everything.
@thesmallstar @Niftyy sir i just committed the previous task with some changes. i hope the changes expected have been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The directory name inside the "Task - 1" directory must be your enrollment number, in your case which is "photos" I believe, please change it.
Sir i had uploaded another one. Named by my roll no.
…On Fri, 13 Dec 2019, 00:38 Tushar Singh, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
The directory name inside the "Task - 1" directory must be your enrollment
number, in your case which is "photos" I believe, please change it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4?email_source=notifications&email_token=AN67OCNJ24CSO5Q2ECO4QDLQYKDZ5A5CNFSM4JYZXYU2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPA2NFQ#pullrequestreview-331458198>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN67OCLHPDSNJEF5DNEB7R3QYKDZ5ANCNFSM4JYZXYUQ>
.
|
@thesmallstar @Niftyy sir i have made some changes. please merge my pull request too. |
I hope all the content has reached. This was my first PR.