Update paths to be universal #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GedasFX
requested changes
Apr 30, 2024
| @@ -104,9 +104,9 @@ On the plugin sidebar there is a new option to change behavior of plugin to not | |||
| Before your first sync, first you will need to manually run the following command in console: | |||
|
|
|||
| ``` | |||
| /home/deck/homebrew/plugins/decky-cloud-save/rclone bisync --filter-from /home/deck/homebrew/settings/decky-cloud-save/sync_paths_filter.txt / backend:decky-cloud-save --copy-links --resync | |||
| ~/homebrew/plugins/decky-cloud-save/rclone bisync --filter-from ~/homebrew/settings/decky-cloud-save/sync_paths_filter.txt / backend:decky-cloud-save --copy-links --resync | |||
There was a problem hiding this comment.
I had issues with relative paths in the past, not sure if this will cause issues here.
There was a problem hiding this comment.
I'm sorry I didn't know how github reviews worked... I left a comment when you made the PR here and didnt realize it was pending. Thought I got ghosted 😅
There was a problem hiding this comment.
This isn't a relative path change. This just ensures a dynamic home is used before the rest of the path.
There was a problem hiding this comment.
Yeah, looking into this now, this looks alright
GedasFX
approved these changes
Apr 30, 2024
|
@GedasFX why not using decky_plugin.pyi consts? |
|
@Emiliopg91 this is in readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other alternative OS's, namely ChimeraOS can and do use Deck Loader. Update the paths to reflect the user home directory.