Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci and make compatible with Ember 5 #1

Merged
merged 29 commits into from
May 21, 2023
Merged

Fix ci and make compatible with Ember 5 #1

merged 29 commits into from
May 21, 2023

Conversation

Gaurav0
Copy link
Owner

@Gaurav0 Gaurav0 commented May 13, 2023

Merges ember-fastboot#898 , ember-fastboot#907, and ember-fastboot#915

fastboot-shoebox-test was broken by ember-fastboot#905

Anyone is free to pick up this PR and fix the remaining tests for Ember 5.

bobisjan and others added 11 commits July 8, 2022 07:35
When running against Ember 4.4 our CI was failing, because
ember-cli-babel incorrectly gets confused about which actual
ember-source is in use.

---

Without this change, the various ember-cli-babel processes were
identifying that ember-source@3.26 was in use and was therefore
transpiling all `@ember/***` module usage to `Ember` global usage. This
is "fine" for Ember 3.26, but under 3.27+ "real" modules exist and
globals rewriting is no longer needed.
@Gaurav0 Gaurav0 force-pushed the fix_ci branch 2 times, most recently from 3222a72 to acd5700 Compare May 13, 2023 12:01
@Gaurav0 Gaurav0 changed the title Fix ci WIP: Fix ci May 13, 2023
@Gaurav0 Gaurav0 force-pushed the fix_ci branch 4 times, most recently from 38cf419 to 74a747e Compare May 13, 2023 19:52
@Gaurav0 Gaurav0 force-pushed the fix_ci branch 2 times, most recently from 21e63a7 to 080dcda Compare May 14, 2023 16:12
@Gaurav0 Gaurav0 force-pushed the fix_ci branch 2 times, most recently from 7a16150 to b786946 Compare May 14, 2023 17:06
@Gaurav0 Gaurav0 changed the title WIP: Fix ci Fix ci and make compatible with Ember 5 May 21, 2023
@Gaurav0 Gaurav0 merged commit dd9d235 into master May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants