Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY out WP_BASE_URL definition into package.json #913

Merged
merged 1 commit into from
Sep 24, 2024
Merged

DRY out WP_BASE_URL definition into package.json #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/wordpress-org-screenshots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ jobs:
npm run playground -- --blueprint=./localized_blueprint.json & \
sleep 60 && \
echo 'Playground is ready now, lets take some pictures.' && \
WP_BASE_URL='http://127.0.0.1:9400/' \
DEBUG=pw:api,pw:webserver \
# DEBUG=pw:api,pw:webserver \
npm run screenshots:wporg

- name: Updating the Screenshots
Expand All @@ -166,8 +165,7 @@ jobs:
npm run playground -- --blueprint=./localized_blueprint.json & \
sleep 60 && \
echo 'Playground is ready now, lets take some pictures.' && \
WP_BASE_URL='http://127.0.0.1:9400/' \
DEBUG=pw:api,pw:webserver \
# DEBUG=pw:api,pw:webserver \
npm run screenshots:wporg -- --update-snapshots

- name: Commit updated screenshots
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@
"packages-update": "wp-scripts packages-update",
"plugin-zip": "wp-scripts plugin-zip",
"start": "wp-scripts start",
"screenshots:wporg": "wp-scripts test-playwright --config .github/scripts/wordpress-org-screenshots/playwright.config.ts",
"screenshots:wporg:debug": "wp-scripts test-playwright --config .github/scripts/wordpress-org-screenshots/playwright.config.ts --debug",
"screenshots:wporg:ui": "wp-scripts test-playwright --config .github/scripts/wordpress-org-screenshots/playwright.config.ts --ui",
"screenshots:wporg": "WP_BASE_URL='http://127.0.0.1:9400/' wp-scripts test-playwright --config .github/scripts/wordpress-org-screenshots/playwright.config.ts",
"screenshots:wporg:debug": "npm run screenshots:wporg -- --debug",
"screenshots:wporg:ui": "npm run screenshots:wporg -- --ui",
"test:e2e": "playwright test --config=playwright.config.js",
"test:unit:js": "wp-scripts test-unit-js --coverage --testResultsProcessor=jest-sonar-reporter",
"pretest:unit:php": "wp-env start --xdebug",
Expand Down
Loading