Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRY Fixing the playground-preview for outside collaborators. #749

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

carstingaxion
Copy link
Collaborator

@carstingaxion carstingaxion commented Jul 31, 2024

Description of the Change

I'm looking for the playground preview once again. And I need the workflow to be in the repo first, like I described in the original PR, but missed an important aspect, that should be fixed with the new trigger pull_request_target, which I introduce with this PR.

Closes # Follow-up bug-fix for #666 & #741

How to test the Change

Changelog Entry

Fixed - Bug fix

Credits

Props @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

what-the-diff bot commented Jul 31, 2024

PR Summary

  • Modified GitHub Actions Workflow Trigger
    The rules governing when our system checks for code changes and updates have been altered. Previously, these checks would occur any time a new proposal for a change was made (referred to as a "pull request"). We have now changed this so the checks will only be initiated when someone is looking to merge their changes into the main version of the product (now referred to as "pull_request_target").

  • Expanded the list of monitored paths
    We now track changes and updates for the file named 'playground-preview.yml' which is situated in '.github/workflows'. This means if there are any changes to this specific file, our system will know about it and react accordingly. This adds another layer of monitoring to ensure the robustness and efficiency of our product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants