extra environment variables for configuring wsUrl (e.g., "wss://" instead of "ws://") #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocker config template and entrypoint
|
Looks good! I just want to test it and wont have time until either tomorrow or Friday but once I test I will merge. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to serve my Lightspeed-react Docker container over https, i've found that i need to configure wsUrl so that it uses the "wss://" scheme instead of "ws://". i also need to set the host to an actual domain name rather than an IP address, presumably because my SSL certificate is only valid for the former.
this patch makes it possible to do this by allowing the user to set WEBSOCKET_SCHEME and WEBSOCKET_HOSTNAME environment variables. if these are not set, they are replaced with "ws://" and $WEBSOCKET_HOST respectively, so the patch should be backwards compatible.