Replace getInt8PtrTy which has now been removed from upstream LLVM #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasilvanus
reviewed
Dec 4, 2023
This function was changed to return just getPtrTy some time ago in upstream LLVM, but the function was left in place to assist updating. The upstream function has now been removed with the instruction that anything using the getInt8PtrTy builder function should switch to getPtrTy. The code here is still required to work with typed pointers, so it is updated to work in both cases.
Test summary for commit b9723c0CTS tests (Failed: 0/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Test summary for commit 9e13304CTS tests (Failed: 0/138378)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Flakebi
approved these changes
Dec 4, 2023
qiaojbao
pushed a commit
that referenced
this pull request
Jan 2, 2024
…2864) This function was changed to return just getPtrTy some time ago in upstream LLVM, but the function was left in place to assist updating. The upstream function has now been removed with the instruction that anything using the getInt8PtrTy builder function should switch to getPtrTy. The code here is still required to work with typed pointers, so it is updated to work in both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was changed to return just getPtrTy some time ago in upstream LLVM, but the function was left in place to assist updating.
The upstream function has now been removed with the instruction that anything using the getInt8PtrTy builder function should switch to getPtrTy.
Since the updates for this happened several months ago, I'm not adding version guards.