-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rust-toolchain
file
#3370
Add rust-toolchain
file
#3370
Conversation
5c7f92b
to
ab39263
Compare
937041e
to
39472ac
Compare
I'm actually going to close this because I just couldn't find a convenient way of doing it. The action we currently use doesn't fully support our case and it's unmaintained so there's nothing we can do besides forking. There's an alternative but maintainer of that is refusing to implement support for the file. (This comment summarizes the situation well: actions-rs/toolchain#126 (comment)) I'll revisit if the situation changes. |
The toolchain file is used to pin a project to a certain version of the Rust toolchain.
We currently do not specify an actual version anywhere but just
stable
so I have followed that, but pinning it to an actual version like1.65
could prevent new Clippy lints, etc. breaking our CI process when there's a new release.Though, the file is useful even with just
stable
since it helps us clean the CI YAMLs.Note: The current format of this file is actually TOML, but the GH action we're using doesn't support it yet so I had to use the legacy format. (The GH action also seems to be unmaintained: actions-rs/toolchain#216)