feat: move from BigNumber to BigInt #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
luizstacio
approved these changes
May 12, 2022
| // This is to align the bits to the total bytes | ||
| // See https://github.com/FuelLabs/fuel-specs/blob/master/specs/protocol/abi.md#unsigned-integers | ||
| length: number; | ||
| baseType: string; | ||
| baseType: TType; |
There was a problem hiding this comment.
Maybe rename it to BaseType?
|
@AlicanC Should we add this to the typedoc list? |
Yeah, nice catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
@fuel-ts/mathwhich has some utilities for working with bigints. This is a copy from Ethers v6 and we can move to their package when that's out of beta.@ethersproject/bignumberand uses native bigints instead.Notes:
transactionspackage, instead of changing all BigNumbers to BigInts, I changed the ones lte u32 to justnumber. They are mostly lengths and indexes and those are natively represtented as numbers and not bigints in JS so this makes our APIs more convenient.