Derive Clone for InflateState to allow random-access reads #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am implementing Seek for a wrapper that reads deflated files. To do this, I will inflate the file once and save the dictionary and inflate state at several points in the file. Later, when I want to seek to some random place in the file, I will use the cloned state+dict to position to a known file position and then inflate until I reach the data I need. To support this, I need to be able to Clone the InflateState and its parts (the current dictionary). Derive Clone for InflateState, HuffmanTable and DecompressorOxide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am implementing Seek for a wrapper that reads deflated files. To do this, I will inflate the file once and save the dictionary and inflate state at several points in the file. Later, when I want to seek to some random place in the file, I will use the cloned state+dict to position to a known file position and then inflate until I reach the data I need.
To support this, I need to be able to Clone the InflateState and its parts (the current dictionary). Derive Clone for InflateState, HuffmanTable and DecompressorOxide.
Add tests: partial stream resumption; partial resume with a cloned state variable.