Bugfix(layoutSize) fix item not render after initial data size is empty #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if layoutSize is provided, items doesn't render if the initial data size is empty. add new function to componentCompact to allow extended component to had access to the _hasRenderOnce only assign the state is the component never get render before
shawnchendev
commented
May 29, 2024
| "file-directives": "1.4.6", | ||
| "tslint": "5.11.0", | ||
| "typescript": "3.3.1" |
There was a problem hiding this comment.
update typescript to a more recent version. because i couldnt get the tslint to run
naqvitalha
approved these changes
May 29, 2024
ananyachandra14
approved these changes
May 30, 2024
ananyachandra14
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address two issues
Issue 1
this will fix flash-list issue Shopify/flash-list#784
if layoutSize is provided, items doesn't render if the initial data size is empty.
add new function to componentCompact to allow extended component to had access to the _hasRenderOnce
only assign the state is the component never get render before
Here is the screen capture i had for the Shopify POS that reproduce the issue
BEFORE
before.recyclerlistview.mp4
AFTER
after.recyclerlistview.mp4
Issue 2
after fixing issue 1, when navigate to the list. the content size will increase by the estimatedItemSize
here is the screenshot and video demo on SHOPIFY POS on the issue
RPReplay_Final1715890031.mp4