add useCallableFunctionResponse #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuleatt
commented
Sep 10, 2021
| * @param functionName - The name of the function to call | ||
| * @param options | ||
| */ | ||
| export function useCallableFunctionResponse<RequestData, ResponseData>( |
There was a problem hiding this comment.
☝️ this is where it is implemented
jhuleatt
commented
Sep 10, 2021
| const observableId = `functions:callableResponse:${functionName}:${JSON.stringify(options?.data)}:${JSON.stringify(options?.httpsCallableOptions)}`; | ||
| const obsFactory = rxHttpsCallable<RequestData, ResponseData>(functions, functionName, options?.httpsCallableOptions); | ||
|
|
||
| //@ts-expect-error because RxFire doesn't make data optional. Remove when https://github.com/FirebaseExtended/rxfire/pull/34 is released. |
There was a problem hiding this comment.
jhuleatt
commented
Sep 10, 2021
|
|
||
| ```jsx | ||
| function LikeCount({ videoId }) { | ||
| const { status, data: likeCount } = useCallableFunctionResponse('countVideoLikes', { data: { videoId: videoId } }); |
There was a problem hiding this comment.
What do you think about the name useCallableFunctionResponse? It's a little wordy because I wanted to emphasize that this would call the callable function and update with the response. Any suggestions to make it shorter/better?
There was a problem hiding this comment.
Wordy but I like that it's very explicit. SGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the
useCallableFunctionResponsehook, which makes it easy to call a callable function on render.fixes #447
Code sample
Note: We also discuss
useGetCallableFunctionin #447, but I've left that out of this PR. After some more thought, I don't think it is worth the maintenance burden, since it is easy enough to use the Firebase JS SDK directly for that use case: