-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useAnalytics missing in ReactFire v4 #429 #431
useAnalytics missing in ReactFire v4 #429 #431
Conversation
…ws to Google Analytics for Firebase with React Router
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @shiiinji! I've left a few comments, but once they're resolved I'd be happy to merge this.
"@firebase/analytics-types" "0.7.0-2021720181311" | ||
"@firebase/component" "0.5.6-2021720181311" | ||
"@firebase/util" "1.3.0-2021720181311" | ||
"@firebase/analytics-compat@0.1.0": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that the lockfile changed! I'm going to push a separate commit to fix this, since it's not related to the scope of this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is the commit on the main
branch: cc0c93e
Co-authored-by: Jeff <3759507+jhuleatt@users.noreply.github.com>
Co-authored-by: Jeff <3759507+jhuleatt@users.noreply.github.com>
Co-authored-by: Jeff <3759507+jhuleatt@users.noreply.github.com>
I appreciate your great feedbacks. |
One more change - can you please run |
I run yarn docs and commited the auto-generate reference docs by #d000464. |
Thanks again @shiiinji! These changes are available now with
And will be included in an upcoming release! |
Thank your great feedbacks. |
Description
useAnalytics missing in ReactFire v4
Code sample