Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add remote IP filter to allow a connection from remote kms #692

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Aug 8, 2023

Description

Please add a description of the changes that this PR introduces and the files that
are the most critical to review.

@CLAassistant
Copy link

CLAassistant commented Aug 8, 2023

CLA assistant check
All committers have signed the CLA.

@jaeseung-bae jaeseung-bae changed the title feat: add kms remote IP filter feat: add remote IP filter to allow a connection from remote ostracon-kms Aug 8, 2023
@jaeseung-bae jaeseung-bae self-assigned this Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #692 (44a8045) into main (d971aa4) will increase coverage by 0.09%.
Report is 6 commits behind head on main.
The diff coverage is 76.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
+ Coverage   66.52%   66.62%   +0.09%     
==========================================
  Files         283      285       +2     
  Lines       37869    37915      +46     
==========================================
+ Hits        25192    25260      +68     
+ Misses      10874    10855      -19     
+ Partials     1803     1800       -3     
Files Changed Coverage Δ
config/config.go 79.36% <ø> (ø)
config/toml.go 74.19% <ø> (ø)
privval/utils.go 33.33% <0.00%> (ø)
privval/signer_listener_endpoint.go 88.81% <70.58%> (-2.46%) ⬇️
privval/internal/ip_filter.go 78.26% <78.26%> (ø)
cmd/ostracon/commands/show_validator.go 72.72% <100.00%> (ø)
node/node.go 61.49% <100.00%> (ø)
privval/internal/null_object_filter.go 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

@jaeseung-bae jaeseung-bae marked this pull request as ready for review August 9, 2023 02:07
@jaeseung-bae jaeseung-bae added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Aug 9, 2023
@jaeseung-bae jaeseung-bae changed the title feat: add remote IP filter to allow a connection from remote ostracon-kms feat: add remote IP filter to allow a connection from remote kms Aug 9, 2023
@jaeseung-bae jaeseung-bae changed the title feat: add remote IP filter to allow a connection from remote kms feat: add remote IP filter to allow a connection from remote kms. Aug 9, 2023
@jaeseung-bae jaeseung-bae changed the title feat: add remote IP filter to allow a connection from remote kms. feat: add remote IP filter to allow a connection from remote kms Aug 9, 2023
config/config.go Show resolved Hide resolved
@jaeseung-bae jaeseung-bae requested a review from ulbqb August 9, 2023 10:04
@jaeseung-bae jaeseung-bae force-pushed the feat/kms-ip-filter branch 2 times, most recently from 0aa6e6d to 4658301 Compare August 11, 2023 11:52
@jaeseung-bae jaeseung-bae merged commit 0e64a96 into main Aug 17, 2023
38 checks passed
@jaeseung-bae jaeseung-bae deleted the feat/kms-ip-filter branch August 17, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: IP allowlist for kms
4 participants