Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ibc-go to v4 #246

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Update ibc-go to v4 #246

merged 2 commits into from
Aug 3, 2023

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Aug 3, 2023

Description

This PR updates ibc-go to v4 along with wasmd.

According to v3 to v4 migration guide, there is nothing to handle.

  • ICS27 - Interchain Accounts - Finschia doesn't have ICA controller.
  • ICS29 - Fee Middleware - Finschia doesn't have 29-fee.
  • Migration to fix support for base denoms with slashes - This is needed only when updating ibc-go from v3.1.0 or below to over. See support denoms with slashes.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@CLAassistant
Copy link

CLAassistant commented Aug 3, 2023

CLA assistant check
All committers have signed the CLA.

@ulbqb ulbqb requested review from 0Tech, zemyblue and dudong2 and removed request for 0Tech and zemyblue August 3, 2023 10:22
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #246 (601e6dd) into main (2e6b3e1) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   44.94%   44.94%           
=======================================
  Files           8        8           
  Lines        1068     1068           
=======================================
  Hits          480      480           
  Misses        570      570           
  Partials       18       18           
Files Changed Coverage Δ
ante/ante.go 0.00% <ø> (ø)
app/app.go 84.12% <100.00%> (ø)

@ulbqb ulbqb merged commit 24eb111 into Finschia:main Aug 3, 2023
33 checks passed
@ulbqb ulbqb deleted the feat/ibc_v4 branch August 3, 2023 11:18
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants