feat: compile static binary as release assets and docker image #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
zemyblue
requested review from
torao,
tnasu,
0Tech,
dudong2,
shiki-tak,
loin3 and
jaeseung-bae
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
4 tasks
Signed-off-by: zemyblue <zemyblue@gmail.com>
jaeseung-bae
previously approved these changes
Jun 21, 2023
0Tech
reviewed
Jun 22, 2023
There was a problem hiding this comment.
We get similar binaries by several logics, by Makefile or by Dockerfile. This pr adds the way even more. We should consider tidy up the logics. We can reuse some logics in the other logics.
Also, we should concentrate on the main targets. The others just increases our burden on maintenance & QA.
Yes, there are meny build option and it is a little complex. I also think It need to arrange it. I'll add as a issue it. And I'll try to fix it as another pr. |
Signed-off-by: zemyblue <zemyblue@gmail.com>
0Tech
previously approved these changes
Jun 23, 2023
jaeseung-bae
previously approved these changes
Jun 23, 2023
jaeseung-bae
approved these changes
Jun 23, 2023
0Tech
approved these changes
Jun 23, 2023
zemyblue
added a commit
to zemyblue/finschia
that referenced
this pull request
Jun 23, 2023
…hia#221) * build: modify docker image base and binary using static library. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: change the description in readme Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: localnet-docker-build unittest Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change the github action ci for pushing Docker images Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change release build for using static binary assets. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: update changelog Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: parse tag in github action of docker.yml Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change docker build and push trigger Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: remove condition if `pull_request` or not. Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: typo Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: remove debian11 and nonroot base docker image Signed-off-by: zemyblue <zemyblue@gmail.com> --------- Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit 225b581)
This was referenced Jun 23, 2023
zemyblue
added a commit
that referenced
this pull request
Jun 26, 2023
…res (#221, #223) (#225) * feat: add integrated swagger for finschia (#223) * feat: add integrated swagger for finschia. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: update changelog Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: add a ci to check generated code. Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: add a ci to check generated code up-to-date Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: ci error Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit b98ef07008b1a1e93882447e67286a0a2ae6339f) --------- Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit d649d83) * feat: compile static binary as release assets and docker image (#221) * build: modify docker image base and binary using static library. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: change the description in readme Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: localnet-docker-build unittest Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change the github action ci for pushing Docker images Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change release build for using static binary assets. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: update changelog Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: parse tag in github action of docker.yml Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: change docker build and push trigger Signed-off-by: zemyblue <zemyblue@gmail.com> * ci: remove condition if `pull_request` or not. Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: typo Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: remove debian11 and nonroot base docker image Signed-off-by: zemyblue <zemyblue@gmail.com> --------- Signed-off-by: zemyblue <zemyblue@gmail.com> (cherry picked from commit 225b581) * fix: build option error Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: build option error in docker Signed-off-by: zemyblue <zemyblue@gmail.com> * fix: build option error in docker Signed-off-by: zemyblue <zemyblue@gmail.com> --------- Signed-off-by: zemyblue <zemyblue@gmail.com>
4 tasks
This was referenced Jul 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #71 , #203
Changes
fnsadversion in docker image was not displayed.linux/amd64andlinux/arm64)Motivation and context
The release assets cannot execute without install dynamic library(libwasmvm). So it is very uncomfortable.
How has this been tested?
Screenshots (if appropriate):
The sample release assets results.
Checklist:
CHANGELOG.md