Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use upstream's cosmovisor #792

Merged
merged 8 commits into from
Nov 17, 2022
Merged

feat: use upstream's cosmovisor #792

merged 8 commits into from
Nov 17, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Nov 10, 2022

Description

This patch would:

  • remove cosmovisor codes in this repository.
  • add a simple test on cosmovisor v1.4.0 with lbm-sdk simd.
  • add the test to CI.

Motivation and context

The cosmovisor could be decoupled from the simapp, so we decided to use the upstream's.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech marked this pull request as ready for review November 10, 2022 04:18
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested in local(Apple M1 pro), the following error was occurred.

~
11:44AM INF no upgrade binary found, beginning to download it module=cosmovisor
Error: cannot download binary. cannot find binary for os/arch: neither darwin/arm64, nor any
11:44AM ERR error="cannot download binary. cannot find binary for os/arch: neither darwin/arm64, nor any" module=cosmovisor
~

@0Tech
Copy link
Collaborator Author

0Tech commented Nov 11, 2022

When I tested in local(Apple M1 pro), the following error was occurred.

~
11:44AM INF no upgrade binary found, beginning to download it module=cosmovisor
Error: cannot download binary. cannot find binary for os/arch: neither darwin/arm64, nor any
11:44AM ERR error="cannot download binary. cannot find binary for os/arch: neither darwin/arm64, nor any" module=cosmovisor
~

It's quite unlikely, but for the testing, I think it's a viable option. Now the test should succeed on your platform.

@0Tech 0Tech requested a review from zemyblue November 11, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants