Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add UpdateParams to x/foundation #729

Merged
merged 9 commits into from
Oct 19, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Oct 18, 2022

Description

This patch will add UpdateParams endpoint to the x/foundation message server, replacing the corresponding proposal.
It resembles UpdateParams of cosmos-sdk, but the authority must be the foundation operator.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #729 (d0df65b) into main (d4635de) will increase coverage by 0.08%.
The diff coverage is 94.44%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
+ Coverage   61.90%   61.98%   +0.08%     
==========================================
  Files         877      875       -2     
  Lines       98764    98745      -19     
==========================================
+ Hits        61135    61204      +69     
+ Misses      34026    33916     -110     
- Partials     3603     3625      +22     
Impacted Files Coverage Δ
simapp/app.go 86.11% <ø> (-0.03%) ⬇️
x/foundation/codec.go 0.00% <0.00%> (ø)
x/foundation/keeper/proposal.go 88.12% <ø> (+5.18%) ⬆️
x/foundation/keeper/msg_server.go 84.91% <85.71%> (+0.05%) ⬆️
x/foundation/client/testutil/tx.go 100.00% <100.00%> (ø)
x/foundation/msgs.go 86.75% <100.00%> (+0.65%) ⬆️
x/wasm/keeper/keeper.go 86.16% <0.00%> (+0.36%) ⬆️
x/token/msgs.go 34.51% <0.00%> (+4.06%) ⬆️
x/collection/msgs.go 43.88% <0.00%> (+9.44%) ⬆️
x/token/validation.go 87.27% <0.00%> (+16.36%) ⬆️

@0Tech 0Tech marked this pull request as ready for review October 18, 2022 06:33
Copy link
Member

@tkxkd0159 tkxkd0159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit 392277a into Finschia:main Oct 19, 2022
@0Tech 0Tech deleted the foundation_updateparams branch October 19, 2022 06:02
@zemyblue zemyblue added the C:x/foundation x/foundation module label Oct 24, 2022
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants