Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tidy up x/foundation #597

Merged
merged 8 commits into from
Jul 19, 2022
Merged

fix: tidy up x/foundation #597

merged 8 commits into from
Jul 19, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Jul 14, 2022

Description

This patch addresses the following items:

  • Apply lint to the test files
  • Fix minor document errors
  • Add a test for collecting treasury
  • Change error to panic where the error is not caused by user

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #597 (512cf55) into main (728aea5) will increase coverage by 0.07%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
+ Coverage   57.53%   57.61%   +0.07%     
==========================================
  Files         796      796              
  Lines       87526    87479      -47     
==========================================
+ Hits        50362    50397      +35     
+ Misses      34025    33953      -72     
+ Partials     3139     3129      -10     
Impacted Files Coverage Δ
x/foundation/keeper/grpc_query.go 4.49% <0.00%> (+0.14%) ⬆️
x/foundation/keeper/handler.go 58.33% <0.00%> (ø)
x/foundation/keeper/msg_server.go 80.00% <10.00%> (+1.95%) ⬆️
x/foundation/keeper/grant.go 69.76% <28.57%> (+5.93%) ⬆️
x/foundation/keeper/exec.go 78.12% <66.66%> (+1.93%) ⬆️
x/foundation/keeper/vote.go 75.67% <66.66%> (+4.78%) ⬆️
x/foundation/keeper/proposal.go 72.13% <76.92%> (+2.98%) ⬆️
x/foundation/client/testutil/tx.go 99.32% <96.29%> (-0.01%) ⬇️
x/foundation/client/testutil/query.go 100.00% <100.00%> (ø)
x/foundation/client/testutil/suite.go 97.91% <100.00%> (ø)
... and 16 more

@0Tech 0Tech requested a review from zemyblue July 18, 2022 06:40
@0Tech 0Tech marked this pull request as ready for review July 18, 2022 06:40
@0Tech 0Tech requested a review from dudong2 July 18, 2022 06:41
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit aef879d into Finschia:main Jul 19, 2022
@0Tech 0Tech deleted the foundation branch July 19, 2022 02:13
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
@0Tech 0Tech added the C:x/foundation x/foundation module label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants