Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update x/bankplus for deprecation #1223

Merged
merged 57 commits into from
Mar 27, 2024

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Feb 1, 2024

Description

closes: #1212

  • NOTE: This PR has proto breaking change. lbm/bankplus/v1/bankplus.proto has been deleted for deprecation.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@jaeseung-bae jaeseung-bae changed the title Bumpup50 bankplus feat: update x/bankplus to use Finschia/cosmos-sdk Feb 1, 2024
@jaeseung-bae jaeseung-bae self-assigned this Feb 1, 2024
@github-actions github-actions bot added A: CI C:x/foundation x/foundation module labels Feb 2, 2024
@github-actions github-actions bot removed the C:x/foundation x/foundation module label Feb 2, 2024
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider implementing the migration on the app. You may try to implement it on simapp, and if it works, you can open the corresponding PR on Finschia/finschia.

@ulbqb
Copy link
Member

ulbqb commented Mar 20, 2024

How about leaving deprecator in bankplus because it's used by finschia/finschia? And proto files shouldn't be removed.

@jaeseung-bae
Copy link
Contributor Author

jaeseung-bae commented Mar 20, 2024

How about leaving deprecator in bankplus because it's used by finschia/finschia? And proto files shouldn't be removed.

I'm thinking of closing this PR when another PR on finschia/finschia is ready.
As @0Tech recommended, I'll make another PR just for bankplus deprecation logic on finschia/finschia.
finschia-sdk will look like it's never had bankplus before.

@ulbqb
Copy link
Member

ulbqb commented Mar 21, 2024

In my opinion, the repo that has better to have deprecator is finschia-sdk not finschia. If finschia, that makes it hard to follow history of bankplus and that makes proto files scattered.

@jaeseung-bae
Copy link
Contributor Author

tter to have deprecator is finschia-sdk not finschia. If finschia, that makes it hard to follow history of bankplus and that makes proto files scattered.

I agree. It seems better to keep bankplus logic here for history.

Copy link
Member

@ulbqb ulbqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is CI testing bankplus? I suppose setting .github/workflow/test.yml is needed.

simapp/go.mod Outdated Show resolved Hide resolved
x/bankplus/deprecator.go Outdated Show resolved Hide resolved
@ulbqb ulbqb self-requested a review March 25, 2024 02:04
ulbqb
ulbqb previously approved these changes Mar 25, 2024
Copy link
Member

@ulbqb ulbqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/bankplus/deprecator.go Outdated Show resolved Hide resolved
@jaeseung-bae jaeseung-bae requested a review from 0Tech March 26, 2024 05:36
@jaeseung-bae jaeseung-bae merged commit 7c39d83 into Finschia:bumpup50 Mar 27, 2024
29 of 30 checks passed
@jaeseung-bae jaeseung-bae deleted the bumpup50-bankplus branch March 27, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants