Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RESTHeart to CI #649

Merged
merged 39 commits into from
Nov 23, 2023
Merged

Add RESTHeart to CI #649

merged 39 commits into from
Nov 23, 2023

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Nov 6, 2023

Closes #558.

@b1ron b1ron added the code/chore Dance tool code maintenance improvements label Nov 6, 2023
@b1ron b1ron self-assigned this Nov 6, 2023
@b1ron
Copy link
Contributor Author

b1ron commented Nov 6, 2023 •
edited
Loading

It still uses Java 11 temurin 😕

But restheart-core build fails now but it also fails on MongoDB.

@b1ron b1ron marked this pull request as ready for review November 7, 2023 14:09
@b1ron b1ron requested a review from a team as a code owner November 7, 2023 14:09
@b1ron b1ron requested a review from AlekSi November 7, 2023 14:09
@b1ron b1ron enabled auto-merge (squash) November 7, 2023 14:11
@b1ron
Copy link
Contributor Author

b1ron commented Nov 7, 2023

Unrelated, but I am continuously recording tests that fail, so that we can correctly identify those pesky flaky tests.

@b1ron b1ron requested a review from AlekSi November 8, 2023 09:33
AlekSi
AlekSi reviewed Nov 8, 2023
View reviewed changes
tests/restheart.yml Show resolved Hide resolved
.github/workflows/dance.yml Show resolved Hide resolved
@b1ron b1ron requested a review from AlekSi November 9, 2023 08:37
@b1ron
Copy link
Contributor Author

b1ron commented Nov 21, 2023

@AlekSi PTAL.

@AlekSi
Copy link
Member

AlekSi commented Nov 21, 2023

@b1ron #649 (comment), and #634's tests fail

@b1ron b1ron mentioned this pull request Nov 22, 2023
Merged
@b1ron
Copy link
Contributor Author

b1ron commented Nov 23, 2023

@AlekSi PTAL, this can merged now. Setting busy_timeout to 20 seconds prevents SQLITE_BUSY.

AlekSi
AlekSi requested changes Nov 23, 2023
View reviewed changes
tests/restheart.yml Show resolved Hide resolved
@AlekSi AlekSi mentioned this pull request Nov 23, 2023
Open
@b1ron b1ron requested a review from AlekSi November 23, 2023 08:18
@b1ron b1ron merged commit 9659708 into FerretDB:main Nov 23, 2023
45 checks passed
@b1ron b1ron deleted the add-restheart-ci branch December 5, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

Assignees

@b1ron b1ron

Labels
code/chore Dance tool code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run RESTHeart tests on CI
2 participants
@b1ron @AlekSi