Fix orientation change bugs #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turned on onLayout handler for all platforms. Android only: on-screen keyboard resized main container and has own height. https://developer.android.com/training/keyboard-input/visibility.html So for calculate the messages container height need ignore keyboard height.
By using the same formula for messagesContainerHeight in onMainViewLayout as everywhere else.
|
@cooperka Sweet! Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the fix from PR #280 (rebased because of merge conflicts, and @psrustik has been unresponsive) with a fix for issue #413.
Brief summary of issues fixed:
Please see individual commits to get a better sense of the changes. Each commit is very simple on its own, though the full PR diff might be confusing to view all at once.
Tested thoroughly on iOS and Android; please also verify yourself if you can :) Basically just type some long text and rotate the phone / dismiss the keyboard / etc. to try to break it.